[PATCH] D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 06:36:56 PDT 2020


spatel added a comment.

In D87479#2266829 <https://reviews.llvm.org/D87479#2266829>, @craig.topper wrote:

> We don't seem to run LICM after InstCombine in the LTO pipeline if I'm reading the pass manager correctly.

That seems like the root bug...although a 1st hack at changing that didn't result in any regression test fails in llvm/test/Other/* .
If we are inverting this fdiv pattern, then aren't we doing that to all kinds of other loop invariant opportunities too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87479/new/

https://reviews.llvm.org/D87479



More information about the llvm-commits mailing list