[PATCH] D87021: [DebugInfo] Fix emitting DWARF64 type units (10/19).

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 04:22:58 PDT 2020


ikudrin added a comment.

In D87021#2267059 <https://reviews.llvm.org/D87021#2267059>, @dblaikie wrote:

>> The test sources were based on some simple code, but then they were cleared as much as I could.
>
> You mean the IR was modified after compilation? Or that the original C source was simplified as much as possible?

I removed/adjusted some attributes here and there to make the tests smaller and to express mostly what I wanted to test in each particular case. In some cases, like the test for `.debug_macro`, the source was created fully manually, based on existing tests.

> Usually we don't simplify the IR - not worth it/doesn't make things especially more maintainable & more likely to introduce something that makes the IR quirky/not representative of the normal Clang generated IR.

I'll see if I can update the tests in the series so that the IR is fully generated by clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87021/new/

https://reviews.llvm.org/D87021



More information about the llvm-commits mailing list