[PATCH] D87445: [InstCombine] Fix incorrect SimplifyWithOpReplaced transform (PR47322)

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 01:15:23 PDT 2020


aqjune added a comment.

The change makes sense to me.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1205
+      SimplifyWithOpReplaced(FalseVal, CmpRHS, CmpLHS, Q,
+                             /* AllowRefinement */ false) == TrueVal) {
     return FalseVal;
----------------
Is there reason why `SimplifyWithOpReplaced(TrueVal, ....) == FalseVal` is removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87445/new/

https://reviews.llvm.org/D87445



More information about the llvm-commits mailing list