[PATCH] D87420: scudo: Introduce a new mechanism to let Scudo access a platform-specific TLS slot

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 18:50:12 PDT 2020


pcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/tsd_shared.h:12
 
 #include "linux.h" // for getAndroidTlsPtr()
 #include "tsd.h"
----------------
cryptoad wrote:
> Is this still necessary?
No it isn't, removed.


================
Comment at: compiler-rt/lib/scudo/standalone/tsd_shared.h:16
+#if SCUDO_HAS_PLATFORM_TLS_SLOT
+#include "scudo_platform_tls_slot.h"
+#endif
----------------
cryptoad wrote:
> Is there some requirement as to where this should live, or build time include path requirement that should be documented?
Added some documentation here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87420/new/

https://reviews.llvm.org/D87420



More information about the llvm-commits mailing list