[PATCH] D87285: AMDGPU/GlobalISelemitter Support for predicate code that uses operands

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:631
+      assert(State.MIs[InsnID] != nullptr && "Used insn before defined");
+      State.RecordedOperands[StoreIdx] = &State.MIs[InsnID]->getOperand(OpIdx);
+      break;
----------------
arsenm wrote:
> Should assert StoreIdx < array size 
Alternatively, tablegen could error if it hits the hardcoded limit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87285/new/

https://reviews.llvm.org/D87285