[PATCH] D87311: [IRSim] Adding commutativity matching to structure checking

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 14:40:58 PDT 2020


jroelofs added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:429
+    const IRSimilarityCandidate &A, const IRSimilarityCandidate &B,
+    SmallVector<Value *, 4> &OperVals, SmallVector<Value *, 4> &OtherOperVals,
+    DenseMap<unsigned, DenseSet<unsigned>> &ValueNumberMapping,
----------------
Can these be `ArrayRef`s instead of `SmallVector&`s?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87311/new/

https://reviews.llvm.org/D87311



More information about the llvm-commits mailing list