[PATCH] D87153: [RFC] BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible

Alexei Starovoitov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 13:16:33 PDT 2020


ast added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:105
+  // Prevent sink common which may create a PHI node for reloc globals.
+  NewInst->addAttribute(AttributeList::FunctionIndex, Attribute::NoMerge);
+  BB->getInstList().insert(Before->getIterator(), NewInst);
----------------
Instead of adding this attribute when bpf_passthrough is inserted by the compiler would it be possible to have this attribute attached to the builtin unconditionally? Meaning that the user could use such builtin in their C code and it would contain NoMerge as well ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87153/new/

https://reviews.llvm.org/D87153



More information about the llvm-commits mailing list