[PATCH] D87418: [LLD] Allow configuring default ld.lld backend

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 13:12:56 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/CMakeLists.txt:196
 
+set(LLD_DEFAULT_LD_LLD_BACKEND "ELF"
+    CACHE STRING "Default backend for ld.lld, can be either ELF (default) or MINGW")
----------------
How about a boolean variable `LLD_DEFAULT_LD_LLD_IS_MINGW`?

Then you can write `#if LLD_DEFAULT_LD_LLD_IS_MINGW`, a Bazel based build system which does not need to this variable (my users) does not need any change.
Additionally, the gn build will not break.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87418/new/

https://reviews.llvm.org/D87418



More information about the llvm-commits mailing list