[PATCH] D87475: Use pragmas to work around MSVC x86_32 debug miscompile bug

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 12:56:55 PDT 2020


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

Thank you so much Reid for taking the time to look into this, discovering the msvc issue and proposing this work-around!



================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerInfoTest.cpp:413
+TEST(LegalizerInfoTest, MSVCDebugMiscompile) {
+  const LLT s1 = LLT::scalar(1);
+  const LLT p0 = LLT::pointer(0, 32);
----------------
nit: fix clang-tidy warnings
s/s1/S1
s/p0/P0
s/builder/Builder


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87475/new/

https://reviews.llvm.org/D87475



More information about the llvm-commits mailing list