[PATCH] D87337: [PGO] De-Optimizing cold functions based on PGO info (PATCH 1/2)

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

In D87337#2265379 <https://reviews.llvm.org/D87337#2265379>, @rengolin wrote:

> Implementation-wise, this looks good, but I wonder if we could join minsize with this using the same (or very similar) controls.

As I mentioned in the RFC thread, I think it's a good idea :-) Though I prefer to send out a separate review for the optsize / minsize work since I think they should have their own flags, given the fact that they're kinda conflict with optnone here (i.e. it doesn't really make sense to add both optsize and optnone at the same time).
Does that make sense to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87337/new/

https://reviews.llvm.org/D87337