[compiler-rt] 01cdab0 - [gcov] Delete flush_fn_list (unused since D83149)

Azhar Mohammed via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 10:12:15 PDT 2020


Reverted this in 626209cac0559ebe06a9bd4792fac5d31333c597. It was causing the instrprof-darwin-exports.c test to fail.

```
Undefined symbols for architecture x86_64:
 "_flush_fn_list", referenced from:
    -exported_symbol[s_list] command line option
```

Refer to http://green.lab.llvm.org/green/job/clang-stage1-RA/14395/consoleFull#-1345203688254eaf0-7326-4999-85b0-388101f2d404 <http://green.lab.llvm.org/green/job/clang-stage1-RA/14395/consoleFull#-1345203688254eaf0-7326-4999-85b0-388101f2d404>.

-
Azhar

> On Sep 9, 2020, at 5:27 PM, Fangrui Song via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
> Author: Fangrui Song
> Date: 2020-09-09T17:27:30-07:00
> New Revision: 01cdab0b335e21321987505e66f34c24dc55b0d7
> 
> URL: https://github.com/llvm/llvm-project/commit/01cdab0b335e21321987505e66f34c24dc55b0d7
> DIFF: https://github.com/llvm/llvm-project/commit/01cdab0b335e21321987505e66f34c24dc55b0d7.diff
> 
> LOG: [gcov] Delete flush_fn_list (unused since D83149)
> 
> Added: 
> 
> 
> Modified: 
>    compiler-rt/lib/profile/GCDAProfiling.c
> 
> Removed: 
> 
> 
> 
> ################################################################################
> diff  --git a/compiler-rt/lib/profile/GCDAProfiling.c b/compiler-rt/lib/profile/GCDAProfiling.c
> index cf6c44bae641..405568187241 100644
> --- a/compiler-rt/lib/profile/GCDAProfiling.c
> +++ b/compiler-rt/lib/profile/GCDAProfiling.c
> @@ -127,11 +127,6 @@ struct fn_list {
>  */
> struct fn_list writeout_fn_list;
> 
> -/*
> - *  A list of flush functions that our __gcov_flush() function should call, shared between all dynamic objects.
> - */
> -struct fn_list flush_fn_list;
> -
> /*
>  *  A list of reset functions, shared between all dynamic objects.
>  */
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200910/0b381abd/attachment.html>


More information about the llvm-commits mailing list