[PATCH] D87272: [lld] Buffer writes when composing a single diagnostic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay planned changes to this revision.
MaskRay added inline comments.


================
Comment at: lld/Common/ErrorHandler.cpp:220
 
     sep = getSeparator(msg);
     ++errorCount;
----------------
andrewng wrote:
> Same locking/race condition for `sep` as above.
Yes. `errorCount` is also racy. This is a big problem. The lock may still be needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87272/new/

https://reviews.llvm.org/D87272