[PATCH] D87161: [DemandedBits][BDCE] Add support for min/max intrinsics

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 09:03:15 PDT 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/DemandedBits.cpp:181-182
+        break;
       }
     break;
   case Instruction::Add:
----------------
Nit: this is where LLVM formatting rules break down. I couldn't tell that we were in a switch-within-an-if-within-a-swich from that single brace/indent. At the least, I'd add braces on the 'if'. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87161/new/

https://reviews.llvm.org/D87161



More information about the llvm-commits mailing list