[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 07:02:07 PDT 2020


Whitney added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:178
+  BitVector PassCategories;
+  std::vector<std::unique_ptr<LoopPassConceptT>> LoopPasses;
+  std::vector<std::unique_ptr<LoopNestPassConceptT>> LoopNestPasses;
----------------
TaWeiTu wrote:
> Whitney wrote:
> > can we use llvm data structures here?
> Since this is a specialized version of `PassManager` and `PassManager` uses `std::vector` instead of the LLVM data structures, I'm not sure which one is better here.
In that case, I agree not to change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87045/new/

https://reviews.llvm.org/D87045



More information about the llvm-commits mailing list