[PATCH] D87391: [Intrinsics] define semantics for experimental fmax/fmin vector reductions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 06:15:30 PDT 2020


spatel updated this revision to Diff 290954.
spatel added a comment.

Patch updated - no code changes, but:

1. Rebased after rG0a5dc7e <https://reviews.llvm.org/rG0a5dc7effb191eff740e0e7ae7bd8e1f6bdb3ad9> (thanks, @nikic !) - so we have optimal lowering in several cases now.
2. Removed some 'FIXME' comments in the Thumb2 file based on above.
3. Added test file for x86 with 'fast' rG1ebb31b1 <https://reviews.llvm.org/rG1ebb31b14cd175b3f272e232958d342221eb875c> to retain coverage for optimal lowerings (not changed with this patch).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87391/new/

https://reviews.llvm.org/D87391

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/lib/CodeGen/ExpandReductions.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/lib/Target/ARM/ARMTargetTransformInfo.h
  llvm/test/CodeGen/AArch64/vecreduce-fmax-legalization-nan.ll
  llvm/test/CodeGen/AArch64/vecreduce-fmax-legalization.ll
  llvm/test/CodeGen/Generic/expand-experimental-reductions.ll
  llvm/test/CodeGen/Thumb2/mve-vecreduce-fminmax.ll
  llvm/test/CodeGen/Thumb2/mve-vecreduce-loops.ll
  llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll
  llvm/test/CodeGen/X86/vector-reduce-fmax.ll
  llvm/test/CodeGen/X86/vector-reduce-fmin-nnan.ll
  llvm/test/CodeGen/X86/vector-reduce-fmin.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87391.290954.patch
Type: text/x-patch
Size: 235303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200910/a1db230f/attachment-0001.bin>


More information about the llvm-commits mailing list