[PATCH] D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/arm64-packed-epilog.s:2
+// REQUIRES: aarch64-registered-target
+// RUN: llvm-mc -filetype=obj -triple aarch64-windows %s -o - \
+// RUN:   | llvm-readobj --unwind - | FileCheck %s
----------------
grimar wrote:
> MaskRay wrote:
> > If the format is important:
> > ```
> > # RUN: llvm-mc -filetype=obj -triple aarch64-windows %s -o - |
> > # RUN:   llvm-readobj --unwind - | FileCheck %s --match-full-lines --strict-whitespace
> > 
> > #      CHECK:ExceptionData {
> > # CHECK-NEXT:  FunctionLength: 4
> > ```
> > 
> > @grimar may prefer keeping the temporary file as `%t`
> Yes, I find it is much more convenient for debugging broken tests to have them.
> It helps to save time - instead of rewriting (and then reverting) such constructions you can just debug an existent temp file.
Sure, I can change that.

A number of the existing related testcases also use the temp-less form, but I can change to using temp files for the newly added tests at least, and cases where I otherwise touch the RUN lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87365/new/

https://reviews.llvm.org/D87365