[PATCH] D87363: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 22:33:58 PDT 2020


mstorsjo added a comment.

In D87363#2264369 <https://reviews.llvm.org/D87363#2264369>, @MaskRay wrote:

>> Also add a missing --strict-whitespace in an existing test that was added explicitly for testing vertical alignment.
>
> Without --match-full-lines, leading and trailing space changes cannot be detected. For `// CHECK: a  b`, you can ensure the spaces between a and b are 2, but you cannot test the indentation.

Yeah - here, `--strict-whitespace` is enough for the thing that the testcase wanted to test (the amount of spaces between the hex opcodes and their interpretation on the right hand side, which was fixed in D86523 <https://reviews.llvm.org/D86523>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87363/new/

https://reviews.llvm.org/D87363



More information about the llvm-commits mailing list