[PATCH] D73739: Exception support for basic block sections

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 15:55:18 PDT 2020


modimo added a comment.

These changes will also apply to other Itanium C++ ABI targets (arm32/arm64/RISCV etc.) so adding testing for at least another target is good. Trying this out for arm64 hits an ICE here:

  case TargetOpcode::EH_LABEL:
    if (MBB.isBeginSection() && MBB.isEHPad() &&
        ((*std::prev(MI.getIterator())).getOpcode() ==
         TargetOpcode::CFI_INSTRUCTION)) {

which is worth following up on.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739



More information about the llvm-commits mailing list