[PATCH] D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 13:55:46 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/include/llvm/MC/MCWinEH.h:32
+    return Offset == I.Offset && Register == I.Register &&
+           Operation == I.Operation;
+  }
----------------
Intentionally not comparing the label?  That seems sort of confusing


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:642
+  // as packed epilog offset.
+  if (Offset <= 31 && PrologCodeBytes <= 124) {
+    info->EpilogMap.clear();
----------------
Maybe early-return -1 here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87369/new/

https://reviews.llvm.org/D87369



More information about the llvm-commits mailing list