[PATCH] D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 13:45:39 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:561
+               Inst.Register == 19) {
+      Inst.Operation = Win64EH::UOP_SaveR19R20X;
+    } else if (Inst.Operation == Win64EH::UOP_AddFP && Inst.Offset == 0) {
----------------
I think at least save_r19r20_x has a different range from the corresponding long opcode.


================
Comment at: llvm/lib/MC/MCWin64EH.cpp:570
+      // as current versions of Windows (up to at least 20.04) is buggy
+      // regarding SaveNext for float pairs.
+    }
----------------
Can we file a spec bug with Microsoft?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87367/new/

https://reviews.llvm.org/D87367



More information about the llvm-commits mailing list