[PATCH] D87149: [InstCombine] erase instructions leading up to unreachable

[stephan.yichao.zhao via Phabricator via llvm-commits]

stephan.yichao.zhao added a comment.

This change affected a case like this:

  code with side effects, for example, volatile stores
  an unreachable instruction __builtin_unreachable

Although executing __builtin_unreachable is undefined, removing the code before it deletes their side effects.

Can we temporarily revert this change and add checking side effect checking for code to be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87149/new/

https://reviews.llvm.org/D87149