[PATCH] D87385: [lib/Object] - Refine interface of ELFFile<ELFT>. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 08:20:09 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, rupprecht, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, kbarton, hiraditya, arichardson, nhaehnle, jvesely, nemanjai, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a project: LLVM.
grimar requested review of this revision.

`ELFFile<ELFT>` has many methods that take pointers,
though they assume that arguments are never null and
hence could take references instead.

This patch performs such clean-up.


https://reviews.llvm.org/D87385

Files:
  lld/ELF/Arch/AMDGPU.cpp
  lld/ELF/Arch/Hexagon.cpp
  lld/ELF/Arch/Mips.cpp
  lld/ELF/Arch/MipsArchTree.cpp
  lld/ELF/Arch/PPC64.cpp
  lld/ELF/Arch/RISCV.cpp
  lld/ELF/Driver.cpp
  lld/ELF/InputFiles.cpp
  lld/ELF/InputSection.cpp
  lld/ELF/Relocations.cpp
  llvm/include/llvm/Object/ELF.h
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
  llvm/lib/InterfaceStub/ELFObjHandler.cpp
  llvm/lib/Object/ELF.cpp
  llvm/tools/llvm-objcopy/ELF/Object.cpp
  llvm/tools/llvm-objdump/ELFDump.cpp
  llvm/tools/llvm-readobj/ARMEHABIPrinter.h
  llvm/tools/llvm-readobj/DwarfCFIEHPrinter.h
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87385.290745.patch
Type: text/x-patch
Size: 104113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200909/4dc01787/attachment.bin>


More information about the llvm-commits mailing list