[PATCH] D48803: Place the BlockAddress type in the program address space

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:3394
+            nullptr, "", nullptr, GlobalValue::NotThreadLocal,
+            M->getDataLayout().getProgramAddressSpace());
+      }
----------------
Why wouldn't this come from the parent function? You should be able to mix functions with different address spaces in the same module


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48803/new/

https://reviews.llvm.org/D48803