[PATCH] D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD)

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:4989
+      Value *Ptr = nullptr;
+      if (getValueTypePair(Record, Slot, NextValueNo, Ptr, &FullTy))
         return error("Invalid record");
----------------
courbet wrote:
> gchatelet wrote:
> > Each function taking `Slot` (previously `OpNum`) will increase it if successful.
> > This allows to replace `OpNum + X` by its value.
> I don't think there is any guarantee that they increase it by one. This could break silently in the future...
Nevermind, I'm commenting on the old patch, I though I was looking at the new one...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83375/new/

https://reviews.llvm.org/D83375