[PATCH] D86748: [libunwind] Bare-metal DWARF: set dso_base to 0

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 20:39:29 PDT 2020


rprichard added a comment.

In D86748#2262437 <https://reviews.llvm.org/D86748#2262437>, @compnerd wrote:

> Why not use `-1` as the indicator instead of `0`?

Just to be sure, the proposal is to use 0 for dso_base and -1 for DwarfFDECache::findFDE to mean "search everything"?

I think that will work, because -1 seems unlikely to appear as a genuine dso_base.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86748/new/

https://reviews.llvm.org/D86748



More information about the llvm-commits mailing list