[PATCH] D86968: [IRSim] Adding IR Instruction Mapper

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:301
+
+  IRInstructionMapper(BumpPtrAllocator *IDA)
+      : InstDataAllocator(IDA){
----------------
paquette wrote:
> Do you need both constructors?
> 
> Would something like the suggested edit above work?
I don't even think we need the nullptr.  In the next patch, I think the empty constructor is removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86968/new/

https://reviews.llvm.org/D86968