[PATCH] D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 00:57:31 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with comment update.



================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-str.yaml:104-105
+## d) Test that yaml2obj stops parsing the .debug_str section if it encounters a
+## string without a null terminator. Here, we use the raw content section instead of
+## the DWARF tag to generate the broken .debug_str section.
+
----------------
This is what I meant. Your comment suggested it was the input that was important, whereas I'm interested in explaining that it's the output that we're testing here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87261/new/

https://reviews.llvm.org/D87261



More information about the llvm-commits mailing list