[PATCH] D87148: [ImplicitNullCheck] Handle Nonzero faulting pages and complex addressing

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 19:52:15 PDT 2020


anna added inline comments.


================
Comment at: llvm/test/CodeGen/X86/implicit-null-check-negative.ll:132
 }
+!startaddress_faulting_pages = !{!1, !2}
 !0 = !{}
----------------
I added these to show that none of the negative test cases start failing once we add the metadata with "other faulting pages". 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87148/new/

https://reviews.llvm.org/D87148



More information about the llvm-commits mailing list