[PATCH] D80506: Add __divmodti4 to match libgcc.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 18:38:08 PDT 2020


MaskRay added inline comments.


================
Comment at: compiler-rt/test/builtins/Unit/divmodti4_test.c:84
+
+    if (test__divmodti4(make_ti(0x8000000000000000LL, 0), 1, make_ti(0x8000000000000000LL, 0), 0x0LL))
+        return 1;
----------------
craig.topper wrote:
> MaskRay wrote:
> > There is no test where the divisor has its high bits set. Will be good adding some coverage here.
> You mean just the high bit set?
The high word. All the existing tests set the high word to 0. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80506/new/

https://reviews.llvm.org/D80506



More information about the llvm-commits mailing list