[PATCH] D80506: Add __divmodti4 to match libgcc.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 16:54:59 PDT 2020


MaskRay added inline comments.


================
Comment at: compiler-rt/test/builtins/Unit/divmodti4_test.c:26
+
+int test__divmodti4(ti_int a, ti_int b, ti_int expected_q, ti_int expected_r)
+{
----------------
Some existing builtins files do not strictly stick with the style but newer tests should place `{` at the line end.


================
Comment at: compiler-rt/test/builtins/Unit/divmodti4_test.c:61
+#ifdef CRT_HAS_128BIT
+    if (test__divmodti4(0, 1, 0, 0))
+        return 1;
----------------
The values can be organized as an array of structures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80506/new/

https://reviews.llvm.org/D80506



More information about the llvm-commits mailing list