[PATCH] D87227: [SVE] Fix isLoadInvariantInLoop for scalable vectors

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 01:53:18 PDT 2020


david-arm created this revision.
david-arm added reviewers: sdesmalen, ctetreau, fpetrogalli.
Herald added subscribers: llvm-commits, psnobl, asbirlea, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a reviewer: efriedma.
Herald added a project: LLVM.
david-arm requested review of this revision.

I've amended the isLoadInvariantInLoop function to bail out for
scalable vectors for now since the invariant_start intrinsic does
not currently work for scalable vectors. Whilst writing tests I
also fixed up a warning in TargetTransformInfoImpl::getGEPCost due
to the implicit cast of TypeSize -> uint64_t. The code currently
doesn't support scalable base offsets so I changed it to use the
scale parameter instead.

Added new tests here:

  Transforms/LICM/AArch64/sve-load-hoist.ll


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87227

Files:
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/test/Transforms/LICM/AArch64/lit.local.cfg
  llvm/test/Transforms/LICM/AArch64/sve-load-hoist.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87227.290206.patch
Type: text/x-patch
Size: 4757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200907/2ec1ead5/attachment.bin>


More information about the llvm-commits mailing list