[PATCH] D86525: [ARM][CostModel] CodeSize costs for i1 arith ops

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 01:16:02 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1043
+  int ISDOpcode = TLI->InstructionOpcodeToISD(Opcode);
+  if (ST->isThumb() && CostKind == TTI::TCK_CodeSize && Ty->isIntegerTy(1)) {
+    // Make operations on i1 relatively expensive as this often involves
----------------
I was wondering if this should be ST->isThumb2() perhaps? Or does it not matter, this didn't show unexpected regressions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86525/new/

https://reviews.llvm.org/D86525



More information about the llvm-commits mailing list