[PATCH] D86867: [obj2yaml] Add support for dumping the .debug_str section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 01:03:16 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:213
+
+      return (bool)RawSec->Flags;
+    }
----------------
I'm not sure casting this here is the clearest of things. I'd actually make it more explicit and check it doesn't equal 0 (if the `(bool)` is even required).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86867/new/

https://reviews.llvm.org/D86867



More information about the llvm-commits mailing list