[PATCH] D87200: [SelectionDAGBuilder] Pass fast math flags to getNode calls rather than trying to set them after the fact.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 6 09:13:09 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/fmf-propagation.ll:560
 ; FMFDEBUG:         ch,glue = callseq_end t15, TargetConstant:i64<32>, TargetConstant:i64<0>, t15:1
-; FMFDEBUG:         f64,ch,glue = CopyFromReg afn t16, Register:f64 $f1, t16:1
+; FMFDEBUG:         f64,ch,glue = CopyFromReg t16, Register:f64 $f1, t16:1
 ; FMFDEBUG:       Type-legalized selection DAG: %bb.0 'log2_approx:'
----------------
spatel wrote:
> We need to find where this flag got dropped?
It was getting a FMF flag before because it was the last instruction created by handling a call. So the after the fact handling found it. I can’t think of a reason we need FMF on a copy. If we need them anywhere it would be on the CALL_NOP right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87200/new/

https://reviews.llvm.org/D87200



More information about the llvm-commits mailing list