[PATCH] D86665: [GlobalISel][IRTranslator] Generate better conditional branch lowering.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 10:45:21 PDT 2020


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:826
+    if (CI && CI->getZExtValue() == 1 &&
+        (MRI->getType(CondLHS).getSizeInBits() == 1) &&
+        CB.PredInfo.Pred == CmpInst::ICMP_EQ) {
----------------
don't need braces here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86665/new/

https://reviews.llvm.org/D86665



More information about the llvm-commits mailing list