[PATCH] D84625: Execute llvm-lit with the python found by CMake by default

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 07:26:34 PDT 2020


arichardson added a comment.

In D84625#2256429 <https://reviews.llvm.org/D84625#2256429>, @thakis wrote:

> This puts `#!/usr/bin/python3.8` instead of `#!/usr/bin/env python3.8` in llvm-bulid/bin/llvm-lit (in a cmake build). That seems undesirable?

CMake should give an absolute path for Python3_EXECUTABLE . However, I'm not sure if that is also true if you specify it manually on the command line. I guess the same fix as the GN one would work for CMake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84625/new/

https://reviews.llvm.org/D84625



More information about the llvm-commits mailing list