[PATCH] D81558: [NewPM] Introduce PreserveCFG check

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 21:43:27 PDT 2020


kuhar added inline comments.


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:90
+struct CFG {
+  struct BBGuard final : public CallbackVH {
+    BBGuard(const BasicBlock *BB) : CallbackVH(BB) {}
----------------
nit: s/struct/class?


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:92
+    BBGuard(const BasicBlock *BB) : CallbackVH(BB) {}
+    void deleted() override { CallbackVH::deleted(); }
+    virtual void allUsesReplacedWith(Value *) { CallbackVH::deleted(); }
----------------
nit: is this function used?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81558/new/

https://reviews.llvm.org/D81558



More information about the llvm-commits mailing list