[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035
+  const RecordDecl *D = RD->getDefinition();
+  if (D && D->isCompleteDefinition())
+    Size = CGM.getContext().getTypeSize(Ty);
----------------
akhuang wrote:
> dblaikie wrote:
> > When is a definition not a complete definition? (sounds like a line from Alice in Wonderland... but I'm genuinely curious/not sure I understand)
> ha, good question, I copied this without really looking at it. I am also not sure when a definition would not be a complete definition.
Oh, I guess incomplete definition means it's in the process of being defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87062/new/

https://reviews.llvm.org/D87062