[PATCH] D86762: [ELF] Add documentation for --warn-backrefs: a layering check tool

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 14:02:12 PDT 2020


MaskRay added a comment.

In D86762#2255290 <https://reviews.llvm.org/D86762#2255290>, @thakis wrote:

> I don't think this should become the default.
>
> - It's weird semantics that are an implementation artifact of bfd ld. ld64 and link.exe (and lld-link) don't have this requirement, and this is a usability win.
>
> - It doesn't help much with layering since it only enforces that the library order on the link command is in some linear embedding of the topological walk of the dependency dag, which isn't all that useful. Layering checks want to look at the real build graph, so the linker is the wrong place for this.

Discussed with thakis offline, forwarded previous discussions to thakis, and CCed thakis in my latest reply to https://lists.llvm.org/pipermail/llvm-dev/2020-September/144825.html

This patch focuses on the documentation. The "enabling by default" discussion should go to the llvm-dev thread.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86762/new/

https://reviews.llvm.org/D86762



More information about the llvm-commits mailing list