[PATCH] D87034: [KnownBits] Implement accurate unsigned and signed max and min

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 13:03:41 PDT 2020


nikic added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3431
     Known = computeKnownBits(Op.getOperand(0), DemandedElts, Depth + 1);
     if (Known.isUnknown()) break; // Early-out
     Known2 = computeKnownBits(Op.getOperand(1), DemandedElts, Depth + 1);
----------------
Maybe drop this early return. Even if one operand is unknown we can determine something here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87034/new/

https://reviews.llvm.org/D87034



More information about the llvm-commits mailing list