[PATCH] D87016: [DebugInfo] Fix emitting the DW_AT_location attribute for 64-bit DWARFv3 (7/19).

Thu Sep 3 12:06:06 PDT 2020

dblaikie accepted this revision.
dblaikie added inline comments.

================
Comment at: llvm/test/DebugInfo/X86/DW_AT_location-reference.ll:41
+; DWARF32v3-NEXT: DW_AT_location [DW_FORM_data4] (0x00000000
+; DWARF64v3-NEXT: DW_AT_location [DW_FORM_data8] (0x00000000
+; DWARFv4-NEXT:   DW_AT_location [DW_FORM_sec_offset] (0x00000000
----------------
ikudrin wrote:
> dblaikie wrote:
> > Should this be dumped in a different format/more digits to match the number of bytes in the field?
> That is how `DWARFLocationTable::dumpLocationList()` dumps the offset. At that moment, the information about the form of the value is lost.
Fair enough, just a thought to consider/keep in mind at some point. Consistency in dumping seems important if we're going to use longer fields to indicate longer encodings. Only using that strategy sometimes seems like it could be more confusing than helpful.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87016/new/

https://reviews.llvm.org/D87016