[PATCH] D86750: GlobalISel: Port smarter known bits for umin/umax from DAG

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 11:26:00 PDT 2020


foad added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp:725-726
+
+  EXPECT_EQ(0u, KnownUmax.Zero.getZExtValue());
+  EXPECT_EQ(0xffffffffffffff00, KnownUmax.One.getZExtValue());
+}
----------------
arsenm wrote:
> foad wrote:
> > These lines look spurious, or did you mean to test something different here?
> Not sure what you mean
The last two lines are just duplicates of the previous two lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86750/new/

https://reviews.llvm.org/D86750



More information about the llvm-commits mailing list