[PATCH] D87070: [DebugInfo] Make DWARF ignore sizes on forward declared class types.

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/struct-fwd-decl.ll:16-21
+; CHECK: DW_TAG_structure_type
+; CHECK-NEXT: DW_AT_name
+; CHECK-NOT: DW_AT_byte_size
+; CHECK-NEXT: DW_AT_declaration
+; CHECK-NOT: DW_AT_byte_size
+; CHECK: NULL
----------------
dblaikie wrote:
> Thinking about it, perhaps this'd be easier written as:
> ```
> ; CHECK: DW_TAG_structure_type
> ; CHECK-NOT: DW_AT_byte_size
> ; CHECK: {{NULL|DW_TAG}}
> ```
> (I realize, ultimately, this isn't far off just "CHECK-NOT: DW_AT_byte_size" in general, but I think it's probably a good balance)
sure, this seems reasonable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87070/new/

https://reviews.llvm.org/D87070