[PATCH] D86864: [MachineSinking] sink more profitable loads

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 14:52:18 PDT 2020


efriedma added a comment.

Do we need some threshold to limit the analysis?  I'm worried this could get very expensive.



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:890
+    return true;
+
+  // Does these two blocks pair cache as no store before?
----------------
Are the post-dominance checks necessary?  I'm not sure what invariants you're trying to enforce.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86864/new/

https://reviews.llvm.org/D86864



More information about the llvm-commits mailing list