[PATCH] D87021: [DebugInfo] Fix emitting DWARF64 type units (14/19).

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 04:39:47 PDT 2020


ikudrin added a comment.

In D87021#2253899 <https://reviews.llvm.org/D87021#2253899>, @dblaikie wrote:

> General feedback: If you can include the original C source code and whatever compile command was needed to generate the IR in any tests (this includes other patches I've already approved, if possible - not vital, many of the tests have very small IR that's pretty easy to read, but it's a "nice to have") that'd be handy! Makes it easier to eyeball the dump output and understand what it's expecting.

The test sources were based on some simple code, but then they were cleared as much as I could. I guess they may be considered artificial. Do you think it will be beneficial to add the code like the following here?

  struct Foo {int a;};
  Foo foo;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87021/new/

https://reviews.llvm.org/D87021



More information about the llvm-commits mailing list