[PATCH] D87017: [DebugInfo] Fix emitting DWARF64 .debug_str_offsets sections (10/19).

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 04:18:17 PDT 2020


ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp:128
       else
         Asm.OutStreamer->emitIntValue(Entry->getValue().Offset, size);
   }
----------------
dblaikie wrote:
> Hmm - this is the line used to emit the offsets in the string offsets table, right? So how is this working/passing the test? Wouldn't it be str_offsets table be messed/too small?
This line works for `.debug_str_offsets.dwo`, emitting which is fixed in D87018.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87017/new/

https://reviews.llvm.org/D87017



More information about the llvm-commits mailing list