[PATCH] D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19).

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 22:52:35 PDT 2020


ikudrin added a comment.

In D87009#2252622 <https://reviews.llvm.org/D87009#2252622>, @dblaikie wrote:

> Might be too fine-grained and better off rolled into whatever patch exercises this functionality when emitting assembly.

That would require to update a particular method several times and potentially would leave it in a partially updated state because some code paths are hard to reach. I believe that the way of this patch is simple and straightforward, as it changes easily observable code places and ensures that they are now accurate and can be reliably used from the other code parts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87009/new/

https://reviews.llvm.org/D87009



More information about the llvm-commits mailing list