[PATCH] D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 17:26:37 PDT 2020


Dor1s added a comment.

Fangrui, what made you think it's fine to remove documented options and break compatibility for the users of the tool?



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:36
-static cl::opt<bool>
-ClUseSymbolTable("use-symbol-table", cl::init(true),
-                 cl::desc("Prefer names in symbol table to names "
----------------
@MaskRay you silently removed this option and didn't even update the documentation: https://llvm.org/docs/CommandGuide/llvm-symbolizer.html#cmdoption-llvm-symbolizer-use-symbol-table


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83530/new/

https://reviews.llvm.org/D83530



More information about the llvm-commits mailing list