[PATCH] D69411: [MC] Resolve the difference of symbols in consecutive MCDataFragements

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 16:02:17 PDT 2020


jcai19 added a comment.

In D69411#2253462 <https://reviews.llvm.org/D69411#2253462>, @jcai19 wrote:

> In D69411#2253193 <https://reviews.llvm.org/D69411#2253193>, @MaskRay wrote:
>
>> at the very least, if we want to keep it, it should be reordered as my comment says, and don't repeat the name of the variable
>
> Hi @MaskRay, thanks for the comment. By reordering, do you mean moving the definition of SubsectionNumber right after LayoutOrder? I do not understand what difference that would make, would you care to explain a little bit more? Also what by not repeating the name of the variable, I assume you were referring to the comment right above its definition?

NVM. I realized moving it after LayoutOrder would not introduce extra padding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411



More information about the llvm-commits mailing list