[PATCH] D87016: [DebugInfo] Fix emitting the DW_AT_location attribute for 64-bit DWARFv3 (9/19).

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 14:20:29 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good



================
Comment at: llvm/test/DebugInfo/X86/DW_AT_location-reference.ll:41
+; DWARF32v3-NEXT: DW_AT_location [DW_FORM_data4] (0x00000000
+; DWARF64v3-NEXT: DW_AT_location [DW_FORM_data8] (0x00000000
+; DWARFv4-NEXT:   DW_AT_location [DW_FORM_sec_offset] (0x00000000
----------------
Should this be dumped in a different format/more digits to match the number of bytes in the field?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87016/new/

https://reviews.llvm.org/D87016



More information about the llvm-commits mailing list